Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd CFDate, CFTimeZone and make them work with chrono #126
Conversation
core-foundation/src/date.rs
Outdated
| @@ -9,11 +9,17 @@ | |||
|
|
|||
| //! Core Foundation date objects. | |||
|
|
|||
| #[cfg(feature = "with-chrono")] | |||
| extern crate chrono; | |||
This comment has been minimized.
This comment has been minimized.
core-foundation/src/timezone.rs
Outdated
| @@ -9,12 +9,18 @@ | |||
|
|
|||
| //! Core Foundation time zone objects. | |||
|
|
|||
| #[cfg(feature = "with-chrono")] | |||
| extern crate chrono; | |||
This comment has been minimized.
This comment has been minimized.
core-foundation/src/timezone.rs
Outdated
| fn timezone_comparison() { | ||
| let system = CFTimeZone::system(); | ||
| let default = CFTimeZone::default(); | ||
| assert!(system == default); |
This comment has been minimized.
This comment has been minimized.
core-foundation/src/timezone.rs
Outdated
| let offset = FixedOffset::west(28800); | ||
| let tz = CFTimeZone::from_offset(offset); | ||
| let converted = tz.offset_at_date(NaiveDateTime::from_timestamp(0, 0)); | ||
| assert!(offset == converted); |
This comment has been minimized.
This comment has been minimized.
core-foundation/src/date.rs
Outdated
| fn date_equality() { | ||
| let now = CFDate::now(); | ||
| let same_time = CFDate::new(now.abs_time()); | ||
| assert!(now == same_time); |
This comment has been minimized.
This comment has been minimized.
|
I had to implement |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 13, 2017
Add CFDate, CFTimeZone and make them work with chrono <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/126) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ratake commentedNov 11, 2017
•
edited by larsbergstrom
This change is