Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a type parameter to CFArray #127
Merged
Conversation
This was referenced Nov 17, 2017
core-foundation/src/array.rs
Outdated
| impl Drop for CFArray { | ||
| /// A trait describing how to convert from the stored *const c_void to the desired T | ||
| pub trait FromVoid<T> { | ||
| fn from_void(x: *const c_void) -> T; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This puts us on a path to greater type safety when using CFArrays
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 25, 2017
Add a type parameter to CFArray This puts us on a path to greater type safety when using CFArrays <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/127) <!-- Reviewable:end -->
|
|
| impl Drop for CFArray { | ||
| /// A trait describing how to convert from the stored *const c_void to the desired T | ||
| pub trait FromVoid { | ||
| fn from_void(x: *const c_void) -> Self; |
This comment has been minimized.
This comment has been minimized.
|
|
||
| impl FromVoid for CFType { | ||
| fn from_void(x: *const c_void) -> CFType { | ||
| unsafe { TCFType::wrap_under_get_rule(mem::transmute(x)) } |
This comment has been minimized.
This comment has been minimized.
nox
Nov 26, 2017
Member
This is unsound, one can pass 0xdeadbeef as *const c_void or any other arbitrary and trigger UB.
|
Does #134 address this sufficiently? |
bors-servo
added a commit
to servo/core-graphics-rs
that referenced
this pull request
Nov 27, 2017
Add functions to get font tag information This depends on servo/core-foundation-rs#127 for CFArray<u32>. I'm just putting it up for reference right now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/104) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jrmuizel commentedNov 17, 2017
•
edited by larsbergstrom
This puts us on a path to greater type safety when using CFArrays
This change is