Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd runloop source and observer functionality #130
Merged
+74
−4
Conversation
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 23, 2017
Add runloop source and observer functionality I had the need to add a source (from `SCDynamicStoreCreateRunLoopSource`). And since all the add/contains/remove operations were fairly trivial I did not see any reason to not complete them for timers, sources and observers at the same time. Also adding the `CFRunLoopMode` type alias to make the signatures reflect the original API a bit more. Lastly, removing underscore from `_info` since it's actually used. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/130) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
faern commentedNov 23, 2017
•
edited
I had the need to add a source (from
SCDynamicStoreCreateRunLoopSource). And since all the add/contains/remove operations were fairly trivial I did not see any reason to not complete them for timers, sources and observers at the same time.Also adding the
CFRunLoopModetype alias to make the signatures reflect the original API a bit more.Lastly, removing underscore from
_infosince it's actually used.This change is