Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark FromVoid more appropriately as unsafe #134

Merged
merged 1 commit into from Nov 27, 2017
Merged

Conversation

@jrmuizel
Copy link
Collaborator

jrmuizel commented Nov 27, 2017

This change is Reviewable

@nox
Copy link
Member

nox commented Nov 27, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2017

📌 Commit 8514c48 has been approved by nox

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2017

Testing commit 8514c48 with merge 6e9055a...

bors-servo added a commit that referenced this pull request Nov 27, 2017
Mark FromVoid more appropriately as unsafe

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/134)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2017

💔 Test failed - status-travis

@jrmuizel
Copy link
Collaborator Author

jrmuizel commented Nov 27, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2017

@jrmuizel: 🔑 Insufficient privileges: and not in try users

@nox
Copy link
Member

nox commented Nov 27, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2017

Testing commit 8514c48 with merge 4a9328e...

bors-servo added a commit that referenced this pull request Nov 27, 2017
Mark FromVoid more appropriately as unsafe

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/134)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2017

☀️ Test successful - status-travis
Approved by: nox
Pushing 4a9328e to master...

@bors-servo bors-servo merged commit 8514c48 into servo:master Nov 27, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.