Skip to content

/ core-foundation-rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CFMutableDictionary type. #135

Merged
merged 1 commit into from Jan 20, 2018
Merged

Add CFMutableDictionary type. #135

merged 1 commit into from Jan 20, 2018

Conversation

@djg
Copy link
Contributor

djg commented Nov 27, 2017 •
edited by larsbergstrom

Added CFMutableDictionary that presents the mutable dictionary
functions of CF. Tries to present a similar interface as CFDictionary.

Fixes issue #93.

This change is Reviewable
@jdm
jdm requested changes Nov 27, 2017
View changes
core-foundation/src/dictionary.rs Outdated
impl Clone for CFMutableDictionary {
#[inline]
fn clone(&self) -> CFMutableDictionary {
unsafe {

This comment has been minimized.

Sign in to view
@jdm

jdm Nov 27, 2017

Member

self.copy_with_capacity?

This comment has been minimized.

Sign in to view
@djg

djg Nov 28, 2017

Author Contributor

Thanks for the review, @jdm. I pushed the requested changes.
@djg djg force-pushed the djg:dict_mut branch from 389fd6f to 7983482 Nov 28, 2017
@djg
Add CFMutableDictionary type.
Loading status checks…
6a77e37 
Added CFMutableDictionary that presents the mutable dictionary
functions of CF. Tries to present a similar interface as CFDictionary.

Fixes issue #93.
@djg djg force-pushed the djg:dict_mut branch from 7983482 to 6a77e37 Nov 29, 2017
@jdm
Copy link
Member

jdm commented Nov 29, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 29, 2017

📌 Commit 6a77e37 has been approved by jdm
bors-servo added a commit that referenced this pull request Nov 29, 2017
@bors-servo
Auto merge of #135 - djg:dict_mut, r=jdm
Loading status checks…
5aa66a0 
Add CFMutableDictionary type.

Added CFMutableDictionary that presents the mutable dictionary
functions of CF. Tries to present a similar interface as CFDictionary.

Fixes issue #93.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/135)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 29, 2017

⌛ Testing commit 6a77e37 with merge 5aa66a0...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 29, 2017

💔 Test failed - status-travis
@jrmuizel jrmuizel mentioned this pull request Jan 13, 2018
Merged
@jdm
Copy link
Member

jdm commented Jan 16, 2018

@bors-servo retry
bors-servo added a commit that referenced this pull request Jan 17, 2018
@bors-servo
Auto merge of #135 - djg:dict_mut, r=jdm
Loading status checks…
8be0848 
Add CFMutableDictionary type.

Added CFMutableDictionary that presents the mutable dictionary
functions of CF. Tries to present a similar interface as CFDictionary.

Fixes issue #93.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/135)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2018

⌛ Testing commit 6a77e37 with merge 8be0848...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2018

💔 Test failed - status-travis
@jdm
Copy link
Member

jdm commented Jan 17, 2018 •
edited 

error: process didn't exit successfully: `/Users/travis/build/servo/core-foundation-rs/core-foundation/target/debug/deps/core_foundation-a1646b9f32dd17a1` (signal: 4, SIGILL: illegal instruction)

However, the test that was added in this PR passed, so probably preexisting?
@jdm
Copy link
Member

jdm commented Jan 17, 2018

I think it's another instance of #141 that panics during a C callback.
@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2018

⌛ Testing commit 6a77e37 with merge 611201a...
bors-servo added a commit that referenced this pull request Jan 18, 2018
@bors-servo
Auto merge of #135 - djg:dict_mut, r=jdm
Loading status checks…
611201a 
Add CFMutableDictionary type.

Added CFMutableDictionary that presents the mutable dictionary
functions of CF. Tries to present a similar interface as CFDictionary.

Fixes issue #93.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/135)
<!-- Reviewable:end -->
@faern faern mentioned this pull request Jan 18, 2018
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2018

💔 Test failed - status-travis
@jdm
Copy link
Member

jdm commented Jan 18, 2018

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 19, 2018

⌛ Testing commit 6a77e37 with merge 535b893...
bors-servo added a commit that referenced this pull request Jan 19, 2018
@bors-servo
Auto merge of #135 - djg:dict_mut, r=jdm
Loading status checks…
535b893 
Add CFMutableDictionary type.

Added CFMutableDictionary that presents the mutable dictionary
functions of CF. Tries to present a similar interface as CFDictionary.

Fixes issue #93.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/135)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 19, 2018

💥 Test timed out
@jdm
Copy link
Member

jdm commented Jan 19, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 19, 2018

⌛ Testing commit 6a77e37 with merge 3a8e10c...
bors-servo added a commit that referenced this pull request Jan 19, 2018
@bors-servo
Auto merge of #135 - djg:dict_mut, r=jdm
Loading status checks…
3a8e10c 
Add CFMutableDictionary type.

Added CFMutableDictionary that presents the mutable dictionary
functions of CF. Tries to present a similar interface as CFDictionary.

Fixes issue #93.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/135)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 20, 2018

☀️ Test successful - status-travis
Approved by: jdm
Pushing 3a8e10c to master...
@bors-servo bors-servo merged commit 6a77e37 into servo:master Jan 20, 2018
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
code-review/reviewable 3 files, 1 discussion left (jdm)
Details
homu Test successful
Details
@faern faern mentioned this pull request Jan 21, 2018
Closed
@jrmuizel jrmuizel mentioned this pull request Jan 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@djg @jdm @bors-servo
You can’t perform that action at this time.