Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix timing sensitive test #141
Merged
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 15, 2018
Fix timing sensitive test This problem was found when I tried to debug #132 But since that PR grew so large, and this fix was very unrelated to the work in that PR I split it out to a separate one. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/141) <!-- Reviewable:end -->
|
|
|
@jdm :( Broken travis. |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 16, 2018
Fix timing sensitive test This problem was found when I tried to debug #132 But since that PR grew so large, and this fix was very unrelated to the work in that PR I split it out to a separate one. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/141) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
@faern: |
|
@jdm Seems Travis is a bit more healthy now. Try again? :) |
|
@bors-servo retry |
|
@bors-servo p=1 |
bors-servo
added a commit
that referenced
this pull request
Jan 17, 2018
Fix timing sensitive test This problem was found when I tried to debug #132 But since that PR grew so large, and this fix was very unrelated to the work in that PR I split it out to a separate one. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/141) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
faern commentedJan 14, 2018
•
edited by larsbergstrom
This problem was found when I tried to debug #132
But since that PR grew so large, and this fix was very unrelated to the work in that PR I split it out to a separate one.
This change is