Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd possibility to iterate untyped CFArray #154
Merged
+21
−0
Conversation
|
I ran into problems when upgrading rust-font-loader to use the EDIT: I fixed it in rust-font-loader by correctly typing the array. So that is fine. But it should still be possible to just iterate the |
|
This looks good to me. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 27, 2018
Add possibility to iterate untyped CFArray Maybe it was intentional, or maybe it was forgotten. But it is not possible to iterate an untyped array (`CFArray<*const c_void>`) in the `0.5.1` release, it was in `0.4`. This extra `FromVoid` impl on `*const c_void` fixes that. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/154) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
faern commentedJan 27, 2018
•
edited by larsbergstrom
Maybe it was intentional, or maybe it was forgotten. But it is not possible to iterate an untyped array (
CFArray<*const c_void>) in the0.5.1release, it was in0.4.This extra
FromVoidimpl on*const c_voidfixes that.This change is