Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReduce usage of libc crate. #156
Merged
Conversation
|
|
Switch from using `libc` types to `::std::os::raw`. This is a breaking change due to the differences in how `c_void` is defined. `core-foundation-sys` no longer needs the `libc` dependency.
waywardmonkeys
force-pushed the
waywardmonkeys:reduce-libc-usage
branch
from
da7c35b
to
7e7d65b
|
Updated (and force pushed) with merge conflicts addressed. |
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Update core-graphics to 0.7 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/cocoa-rs/156) <!-- Reviewable:end -->
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 2, 2018
Reduce usage of libc crate. Switch from using `libc` types to `::std::os::raw`. This is a breaking change due to the differences in how `c_void` is defined. `core-foundation-sys` no longer needs the `libc` dependency. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/156) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
waywardmonkeys commentedFeb 1, 2018
•
edited by larsbergstrom
Switch from using
libctypes to::std::os::raw. This is a breakingchange due to the differences in how
c_voidis defined.core-foundation-sysno longer needs thelibcdependency.This change is