Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to rustc 0.8-pre (0ac3e02 2013-08-30 05:45:45 -0700) #18
+16
−12
Conversation
This was referenced Sep 2, 2013
This comment has been minimized.
This comment has been minimized.
metajack
commented on 95f2f30
Sep 3, 2013
|
FIXMEs? |
This comment has been minimized.
This comment has been minimized.
|
|
|
@metajack, I added a FIXME comment in the trait definition. If the signature is changed there to remove the dummy parameter, implementations and calls will have a to be changed accordingly to build. Should I still add FIXME comment in all of these? (Including in other repositories that use this trait.) |
This comment has been minimized.
This comment has been minimized.
metajack
commented on e0efe40
Sep 3, 2013
|
r+ |
|
I think just adding it here is fine. |
metajack
added a commit
that referenced
this pull request
Sep 3, 2013
Upgrade to rustc 0.8-pre (0ac3e02 2013-08-30 05:45:45 -0700)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedSep 2, 2013
No description provided.