Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a PathBuf instead of a String #188

Merged
merged 1 commit into from Feb 3, 2018
Merged

Conversation

@jrmuizel
Copy link
Collaborator

jrmuizel commented Feb 3, 2018

This is just better.


This change is Reviewable

This is just better.
@jdm
Copy link
Member

jdm commented Feb 3, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Feb 3, 2018

📌 Commit 21f20e2 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Feb 3, 2018

Testing commit 21f20e2 with merge 16ddf90...

bors-servo added a commit that referenced this pull request Feb 3, 2018
Return a PathBuf instead of a String

This is just better.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/188)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 3, 2018

☀️ Test successful - status-travis
Approved by: jdm
Pushing 16ddf90 to master...

@bors-servo bors-servo merged commit 21f20e2 into servo:master Feb 3, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.