Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upallow creating a CTFont from a CGFont with variations #193
+27
−3
Conversation
added 2 commits
Feb 6, 2018
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 6, 2018
allow creating a CTFont from a CGFont with variations This is functionality necessary to solve https://bugzilla.mozilla.org/show_bug.cgi?id=1435062 We need to be able to pass the variations dictionary to the CTFont, otherwise core-text does not properly handle with the variations on the font. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/193) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lsalzman commentedFeb 6, 2018
•
edited by larsbergstrom
This is functionality necessary to solve https://bugzilla.mozilla.org/show_bug.cgi?id=1435062
We need to be able to pass the variations dictionary to the CTFont, otherwise core-text does not properly handle with the variations on the font.
This change is