Skip to content

/ core-foundation-rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convertRectToBacking to NSView #195

Merged
merged 1 commit into from Feb 7, 2018
Merged

Add convertRectToBacking to NSView #195

merged 1 commit into from Feb 7, 2018

Conversation

@jrmuizel
Copy link
Collaborator

jrmuizel commented Feb 7, 2018 •
edited by larsbergstrom

This change is Reviewable
@jrmuizel
Add convertRectToBacking to NSView
Loading status checks…
b321255
@jdm
Copy link
Member

jdm commented Feb 7, 2018

What about

core-foundation-rs/cocoa/src/appkit.rs

Lines 2789 to 2791 in f86a5fb

unsafe fn convertRectToBacking_(self, aRect: NSRect) -> NSRect {
msg_send![self, convertRectToBacking:aRect]
}
which is already in the NSScreen type like https://developer.apple.com/documentation/appkit/nsscreen/1388389-convertrecttobacking?language=objc?
@jrmuizel
Copy link
Collaborator Author

jrmuizel commented Feb 7, 2018

This is for https://developer.apple.com/documentation/appkit/nsview/1483648-convertrecttobacking. They are not the same method.
@jdm
Copy link
Member

jdm commented Feb 7, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

📌 Commit b321255 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

⌛ Testing commit b321255 with merge 4e499ab...
bors-servo added a commit that referenced this pull request Feb 7, 2018
@bors-servo
Auto merge of #195 - jrmuizel:backing, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4e499ab 
Add convertRectToBacking to NSView

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/195)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

☀️ Test successful - status-travis
Approved by: jdm
Pushing 4e499ab to master...
@bors-servo bors-servo merged commit b321255 into servo:master Feb 7, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jrmuizel @jdm @bors-servo
You can’t perform that action at this time.