Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCFString refactor / cleanup #220
Merged
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 29, 2018
CFString refactor / cleanup This pull request: - removes two unnecessary casts (from `CFIndex` to `usize` and back again) - extracts the to rust string conversion: instead of doing it on-the-fly in the `Display` implementation (and thus only supporting the indirect `ToString` way to get a rust string from a `CFString`, which _always_ allocates) this implements `From<&CFString> for Cow<str>` allowing everyone the possibility of avoiding an allocation if the `CFString` is already formatted in UTF-8. Rebase of #76 (note to self: next time, re-open first, then push). cc @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/220) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
TimNN commentedMay 29, 2018
•
edited by larsbergstrom
This pull request:
CFIndextousizeand back again)Displayimplementation (and thus only supporting the indirectToStringway to get a rust string from aCFString, which always allocates) this implementsFrom<&CFString> for Cow<str>allowing everyone the possibility of avoiding an allocation if theCFStringis already formatted in UTF-8.Rebase of #76 (note to self: next time, re-open first, then push).
cc @jdm
This change is