Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd CF(Mutable)AttributedString and a couple helpers #223
Conversation
|
The commit message should presumably be CFAttr... instead of CGAttr... |
mehcode
changed the title
mehcode
force-pushed the
mehcode:feature/attributed-string
branch
from
c3f4602
to
1d36907
|
Had CG in my brain when I typed that I guess. Fixed. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 6, 2018
Add CF(Mutable)AttributedString and a couple helpers Just declared stuff that I'm using. Copied the basic template from CFString. ---- <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/223) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 1, 2018
Add ItemMutRef and FromMutVoid Used (in my project) to grab a `&mut CFMutableAttributedString` from an objc-c ivar to use methods introduced in #223. ```rust CFMutableAttributedString::from_mut_void(ptr) ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/244) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mehcode commentedJul 6, 2018
•
edited
Just declared stuff that I'm using. Copied the basic template from CFString.
This change is