Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make core_graphics public for other project such as metal-rs to pass… #224

Closed
wants to merge 1 commit into from

Conversation

@Michael-Lfx
Copy link

Michael-Lfx commented Jul 11, 2018

make core_graphics public for other project such as metal-rs to pass iOS compilation


This change is Reviewable

@jrmuizel
Copy link
Collaborator

jrmuizel commented Jul 11, 2018

Why is this needed for iOS compilation?

@Michael-Lfx
Copy link
Author

Michael-Lfx commented Jul 11, 2018

Because metal-rs use NSSize as return value. Compilation for macOS is good. For iOS, there is no NSSize definition in Foundation, instead we could use CGSize which defined in Core Graphics Framework. Here is metal-rs code snippet.

pub fn drawable_size(&self) -> NSSize {
    unsafe {
        msg_send![self, drawableSize]
    }
}

pub fn set_drawable_size(&self, size: NSSize) {
    unsafe {
        msg_send![self, setDrawableSize:size]
    }
}
@jrmuizel
Copy link
Collaborator

jrmuizel commented Jul 11, 2018

Shouldn't metal-rs be using the type from the core graphics crate directly?

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2018

The latest upstream changes (presumably #259) made this pull request unmergeable. Please resolve the merge conflicts.

@jrmuizel
Copy link
Collaborator

jrmuizel commented Aug 28, 2019

Closing for inactivity from author.

@jrmuizel jrmuizel closed this Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.