Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse new objc class macro #226
Merged
+92
−101
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 17, 2018
Use new objc class macro This PR removes the `class` function in favor of the [new `class` macro exposed by objc](SSheldon/rust-objc#65) which caches access by class name. Note that this macro should eventually (through procedural macros) be able to link directly to the class. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/226) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
grovesNL commentedJul 16, 2018
•
edited by larsbergstrom
This PR removes the
classfunction in favor of the newclassmacro exposed by objc which caches access by class name. Note that this macro should eventually (through procedural macros) be able to link directly to the class.This change is