Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcore-foundation: Remove 2 transmutes in macros. #229
Merged
Conversation
These transmutes were going from one type of pointer to another, and so can be done as casts instead. Doing so also means that one unsafe block can be removed. This was found via clippy.
|
@bors-servo r+ |
|
|
|
@bors-servo r+ |
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 20, 2018
core-foundation: Remove 2 transmutes in macros. These transmutes were going from one type of pointer to another, and so can be done as casts instead. Doing so also means that one unsafe block can be removed. This was found via clippy. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/229) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
waywardmonkeys commentedJul 19, 2018
•
edited by larsbergstrom
These transmutes were going from one type of pointer to another,
and so can be done as casts instead.
Doing so also means that one unsafe block can be removed.
This was found via clippy.
This change is