Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd several new functions to Core Graphics and Core Text for `font-kit`'s use. #237
+151
−20
Conversation
|
Travis shows some Cargo.toml files that need to be updated with the new package versions, but otherwise this looks fine. |
core-text/src/font_collection.rs
Outdated
| unsafe { | ||
| CFArray::wrap_under_get_rule(CTFontCollectionCreateMatchingFontDescriptors(self.0)) | ||
| let array = CTFontCollectionCreateMatchingFontDescriptors(self.0); | ||
| if array.is_null() { |
This comment has been minimized.
This comment has been minimized.
pcwalton
force-pushed the
pcwalton:core-graphics-additions
branch
from
a0ec818
to
8e18273
|
Review comments addressed. |
pcwalton
force-pushed the
pcwalton:core-graphics-additions
branch
from
8e18273
to
a37aae7
| @@ -16,5 +16,5 @@ crate-type = ["rlib"] | |||
| block = "0.1" | |||
| bitflags = "1.0" | |||
| libc = "0.2" | |||
| core-graphics = { path = "../core-graphics", version = "0.16" } | |||
| core-graphics = { path = "../core-graphics", version = "0.17" } | |||
This comment has been minimized.
This comment has been minimized.
…t`'s use. This bumps the major version of `core-text` since the previous version of `get_glyphs_for_characters` was unsoundly marked safe before and is now marked unsafe.
pcwalton
force-pushed the
pcwalton:core-graphics-additions
branch
from
a37aae7
to
2434720
|
I updated the Cocoa version (since it's on 0.x, bumped the minor version). |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 25, 2018
Add several new functions to Core Graphics and Core Text for `font-kit`'s use. This bumps the major version of `core-text` since the previous version of `get_glyphs_for_characters` was unsoundly marked safe before and is now marked unsafe. r? @jrmuizel (or whoever) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/237) <!-- Reviewable:end -->
|
|
| @@ -271,6 +316,20 @@ impl CTFont { | |||
| } | |||
| } | |||
|
|
|||
| pub fn get_vertical_translations_for_glyphs(&self, | |||
This comment has been minimized.
This comment has been minimized.
|
Please fix the newly-added unsound method before proceeding with publish of core-text 12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedJul 24, 2018
•
edited by larsbergstrom
This bumps the major version of
core-textsince the previous version ofget_glyphs_for_characterswas unsoundly marked safe before and is now marked unsafe.r? @jrmuizel (or whoever)
This change is