Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake `get_advances_for_glyphs` and `get_vertical_translations_for_glyphs` unsafe. #239
+19
−23
Conversation
|
We didn't publish 12 so you don't the version bump. r=me anyway if you don't want to publish 12 at all and go to 13 directly. |
pcwalton
force-pushed the
pcwalton:unsafe-vertical-translations
branch
from
07285e8
to
46f432e
|
@nox OK, I undid the version bump. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 25, 2018
Make `get_advances_for_glyphs` and `get_vertical_translations_for_glyphs` unsafe. Closes #238. r? @nox <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/239) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedJul 25, 2018
•
edited by larsbergstrom
Closes #238.
r? @nox
This change is