Skip to content

/ core-foundation-rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `CTFontCollection::get_descriptors()` return an Option. #240

Merged
merged 1 commit into from Jul 27, 2018
Merged

Make `CTFontCollection::get_descriptors()` return an Option. #240

merged 1 commit into from Jul 27, 2018
+9 −3

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Jul 27, 2018 •
edited by larsbergstrom

It returns null if there are no matching fonts.

r? @mbrubeck

This change is Reviewable
@pcwalton
Make `CTFontCollection::get_descriptors()` return an Option.
Loading status checks…
f89d234 
It returns null if there are no matching fonts.
@mbrubeck
Copy link
Contributor

mbrubeck commented Jul 27, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2018

📌 Commit f89d234 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2018

⌛ Testing commit f89d234 with merge 8b090bb...
bors-servo added a commit that referenced this pull request Jul 27, 2018
@bors-servo
Auto merge of #240 - pcwalton:get-descriptors-null, r=mbrubeck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8b090bb 
Make `CTFontCollection::get_descriptors()` return an Option.

It returns null if there are no matching fonts.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/240)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2018

☀️ Test successful - status-travis
Approved by: mbrubeck
Pushing 8b090bb to master...
@bors-servo bors-servo merged commit f89d234 into servo:master Jul 27, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@pcwalton @mbrubeck @bors-servo
You can’t perform that action at this time.