Skip to content

/ core-foundation-rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to supply custom data to `CGDataProvider`. #242

Merged
merged 1 commit into from Jul 31, 2018
Merged

Add the ability to supply custom data to `CGDataProvider`. #242

merged 1 commit into from Jul 31, 2018

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Jul 31, 2018 •
edited by larsbergstrom

This is useful for opening memory-mapped files.

r? @mbrubeck

This change is Reviewable
@pcwalton
Add the ability to supply custom data to `CGDataProvider`.
Loading status checks…
12236ce 
This is useful for opening memory-mapped files.
@mbrubeck
Copy link
Contributor

mbrubeck commented Jul 31, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

📌 Commit 12236ce has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

⌛ Testing commit 12236ce with merge b3503c3...
bors-servo added a commit that referenced this pull request Jul 31, 2018
@bors-servo
Auto merge of #242 - pcwalton:cg-data-provider-custom-data, r=mbrubeck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b3503c3 
Add the ability to supply custom data to `CGDataProvider`.

This is useful for opening memory-mapped files.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/242)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

☀️ Test successful - status-travis
Approved by: mbrubeck
Pushing b3503c3 to master...
@bors-servo bors-servo merged commit 12236ce into servo:master Jul 31, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@pcwalton pcwalton deleted the pcwalton:cg-data-provider-custom-data branch Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@pcwalton @mbrubeck @bors-servo
You can’t perform that action at this time.