Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ItemMutRef and FromMutVoid #244

Merged
merged 1 commit into from Aug 1, 2018

Conversation

@mehcode
Copy link
Contributor

mehcode commented Aug 1, 2018

Used (in my project) to grab a &mut CFMutableAttributedString from an objc-c ivar to use methods introduced in #223.

CFMutableAttributedString::from_mut_void(ptr)

This change is Reviewable

@jrmuizel
Copy link
Collaborator

jrmuizel commented Aug 1, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

📌 Commit 085aa65 has been approved by jrmuizel

@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

Testing commit 085aa65 with merge 7a6c809...

bors-servo added a commit that referenced this pull request Aug 1, 2018
Add ItemMutRef and FromMutVoid

Used (in my project) to grab a `&mut CFMutableAttributedString` from an objc-c ivar to use methods introduced in #223.

```rust
CFMutableAttributedString::from_mut_void(ptr)
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/244)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

☀️ Test successful - status-travis
Approved by: jrmuizel
Pushing 7a6c809 to master...

@bors-servo bors-servo merged commit 085aa65 into servo:master Aug 1, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mehcode
Copy link
Contributor Author

mehcode commented Aug 1, 2018

👍 You guys are awesome. Happy to see my additions getting merged in so quickly. I've got quite a bit left as my fork has diverged a good bit but I'm making progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.