Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic NSToolbar #252

Merged
merged 1 commit into from Aug 30, 2018
Merged

Added basic NSToolbar #252

merged 1 commit into from Aug 30, 2018

Conversation

@Litarvan
Copy link
Contributor

Litarvan commented Aug 30, 2018

-> Basic NSToolbar implementation (init, separator, adding to NSWindow)
I needed this for a project, and i wanted to share it.

Empty toolbar example :
Example

Even empty, combined with a fullsized content view and a transparent title bar, this can be very useful (used for example by Firefox, and Atom).


This change is Reviewable

@jrmuizel
Copy link
Collaborator

jrmuizel commented Aug 30, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2018

📌 Commit 1a15654 has been approved by jrmuizel

@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2018

Testing commit 1a15654 with merge 832e337...

bors-servo added a commit that referenced this pull request Aug 30, 2018
Added basic NSToolbar

-> Basic NSToolbar implementation (init, separator, adding to NSWindow)
I needed this for a project, and i wanted to share it.

Empty toolbar example :
![Example](https://user-images.githubusercontent.com/8712146/44870891-954eb980-ac91-11e8-97f5-384ad71baf7a.png)

Even empty, combined with a fullsized content view and a transparent title bar, this can be very useful (used for example by Firefox, and Atom).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/252)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2018

☀️ Test successful - status-travis
Approved by: jrmuizel
Pushing 832e337 to master...

@bors-servo bors-servo merged commit 1a15654 into servo:master Aug 30, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.