Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCgdisplaymode extensions #253
Merged
Conversation
core-graphics/src/display.rs
Outdated
| } else if pixel_encoding.eq_ignore_ascii_case(IO8BitIndexedPixels) { | ||
| depth = 8; | ||
| } | ||
| return depth as usize; |
This comment has been minimized.
This comment has been minimized.
jdm
Sep 11, 2018
Member
Let's write this as:
pub fn bit_depth(&self) -> usize {
let pixel_encoding = self.pixel_encoding().to_string();
// my numerical representation for kIO16BitFloatPixels and kIO32bitFloatPixels
// are made up and possibly non-sensical
if pixel_encoding.eq_ignore_ascii_case(kIO32BitFloatPixels) {
96
} else if ... {
64
...
} else {
0
}
}
core-graphics/src/display.rs
Outdated
| @@ -536,6 +610,19 @@ extern "C" { | |||
| pub fn CGDisplayBounds(display: CGDirectDisplayID) -> CGRect; | |||
| pub fn CGDisplayCreateImage(display: CGDirectDisplayID) -> ::sys::CGImageRef; | |||
|
|
|||
| pub fn CGBeginDisplayConfiguration(config: *const *mut libc::c_void) -> CGError; | |||
This comment has been minimized.
This comment has been minimized.
core-graphics/src/display.rs
Outdated
| pub fn CGBeginDisplayConfiguration(config: *const *mut libc::c_void) -> CGError; | ||
| pub fn CGCancelDisplayConfiguration(config: CGDisplayConfigRef) -> CGError; | ||
| pub fn CGCompleteDisplayConfiguration( | ||
| config: *const libc::c_void, |
This comment has been minimized.
This comment has been minimized.
core-graphics/src/display.rs
Outdated
| option: CGConfigureOption, | ||
| ) -> CGError; | ||
| pub fn CGConfigureDisplayWithDisplayMode( | ||
| config: *const libc::c_void, |
This comment has been minimized.
This comment has been minimized.
|
I have applied all remarks. Is there more things I need to do before this can be merged? |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 18, 2018
Cgdisplaymode extensions I am writing a tool to change resolution on MacOS. For this I needed, more support for CGDisplayMode methods. I also need support for CGConfigureDisplayWithDisplayMode(). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/253) <!-- Reviewable:end -->
|
|
|
Hi, thanks for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bn3t commentedSep 8, 2018
•
edited by larsbergstrom
I am writing a tool to change resolution on MacOS. For this I needed, more support for CGDisplayMode methods. I also need support for CGConfigureDisplayWithDisplayMode().
This change is