Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd initial bindings to Core Animation. #259
Merged
+1,596
−1
Conversation
|
@jrmuizel Do you know things about CoreAnimation? I know nothing. |
|
@mstange has been reviewing my Core Animation related code in Gecko, FWIW. |
mstange
commented
Sep 27, 2018
|
This CoreAnimation-specific parts looks straightfoward to me. What I have trouble with are the generic Objective C parts, and @jrmuizel is a better reviewer for those. For example the string conversion business and the use of |
cocoa/src/quartzcore.rs
Outdated
|
|
||
| /// This is only a snapshot, unlike the corresponding Cocoa API. | ||
| #[inline] | ||
| pub fn sublayers(&self) -> Vec<CALayer> { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Bound types include `CALayer`, `CATransaction`, and `CATransform3D`.
|
@bors-servo: r=jrmuizel |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 27, 2018
Add initial bindings to Core Animation. Bound types include `CALayer`, `CATransaction`, and `CATransform3D`. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/259) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedSep 27, 2018
•
edited by larsbergstrom
Bound types include
CALayer,CATransaction, andCATransform3D.r? @jdm
This change is