Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd constants for new AppKit versions through El Capitan. #266
Conversation
I need this to fix `winit`, because Mojave has some new behavior around layer-backed views and version sniffing is the easiest way to detect when I need to handle it. This also bumps the version to 0.18.3.
|
LGTM, I couldn't check some of the newer appkit versions but the ones that I did check are correct. @bors-servo r+ |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 27, 2018
Add constants for new AppKit versions through El Capitan. I need this to fix `winit`, because Mojave has some new behavior around layer-backed views and version sniffing is the easiest way to detect when I need to handle it. This also bumps the version to 0.18.3. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/266) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedOct 25, 2018
•
edited by larsbergstrom
I need this to fix
winit, because Mojave has some new behavior aroundlayer-backed views and version sniffing is the easiest way to detect when I need to handle it.
This also bumps the version to 0.18.3.
r? @jdm
This change is