Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCFArray, Core Animation, and Quartz Window Services additions #268
Conversation
This is necessary for the bindings to Quartz Window Services to work, since those APIs don't wrap `CGWindowID` objects in `CFNumber` wrappers.
…ndings
`-[CATransaction setCompletionBlock:]` We have support for blocks, so there's no reason to not include these.
This series of functions allows us to take screenshots, which are useful for integration testing.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 2, 2018
CFArray, Core Animation, and Quartz Window Services additions Here's your regularly scheduled set of additions to the Core Foundation bindings. I needed these for the testing infrastructure I'm developing for https://github.com/pcwalton/planeshift. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/268) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedNov 2, 2018
•
edited
Here's your regularly scheduled set of additions to the Core Foundation bindings. I needed these for the testing infrastructure I'm developing for https://github.com/pcwalton/planeshift.
r? @jdm
This change is