Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd some minimal bindings for CTLine and CTRun #269
Merged
Conversation
jrmuizel
force-pushed the
jrmuizel:run
branch
2 times, most recently
from
64ab24c
to
6208eb9
| let mut vec = Vec::with_capacity(count as usize); | ||
| // "If the length of the range is set to 0, then the copy operation will continue | ||
| // from the start index of the range to the end of the run" | ||
| CTRunGetGlyphs(self.0, CFRange::init(0, 0), vec.as_mut_ptr()); |
This comment has been minimized.
This comment has been minimized.
jdm
Nov 7, 2018
Member
We need to call vec.set_len(count) to have a usable vector after this operation.
| let mut vec = Vec::with_capacity(count as usize); | ||
| // "If the length of the range is set to 0, then the copy operation will continue | ||
| // from the start index of the range to the end of the run" | ||
| CTRunGetPositions(self.0, CFRange::init(0, 0), vec.as_mut_ptr()); |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 14, 2018
Add some minimal bindings for CTLine and CTRun <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/269) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 28, 2019
Increase minor version for core-text to 13.2.0. This includes changes from #293 and #269 which only add new public APIs. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/294) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jrmuizel commentedNov 2, 2018
•
edited by larsbergstrom
This change is