Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CF functions for using bookmark data #274

Merged

Conversation

@acheronfail
Copy link
Contributor

acheronfail commented Nov 9, 2018

fixes #116 (a closed issue)

Provides the definitions for some of the CF functions for using Bookmark data (which is useful for sandboxed applications).


This change is Reviewable

fixes #116 (a closed issue)
@acheronfail
Copy link
Contributor Author

acheronfail commented Nov 9, 2018

OOC why are there some definitions that are filled in but commented out?
One example: https://github.com/servo/core-foundation-rs/pull/274/files#diff-68c46b737dc51d7b455898f741abead5R128

@jdm
Copy link
Member

jdm commented Nov 9, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

📌 Commit cf356f6 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

Testing commit cf356f6 with merge 55a4d79...

bors-servo added a commit that referenced this pull request Nov 9, 2018
…=jdm

chore: add CF functions for using bookmark data

fixes #116 (a closed issue)

Provides the definitions for some of the CF functions for using Bookmark data (which is useful for sandboxed applications).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/274)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

☀️ Test successful - status-travis
Approved by: jdm
Pushing 55a4d79 to master...

@bors-servo bors-servo merged commit cf356f6 into servo:master Nov 9, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@acheronfail acheronfail deleted the acheronfail:chore/add-cf-bookmark-definitions branch Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.