Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: Don't call expect with the result of a function call. #295

Conversation

@waywardmonkeys
Copy link
Contributor

waywardmonkeys commented Mar 14, 2019

This change is Reviewable

@jdm
Copy link
Member

jdm commented Mar 14, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2019

📌 Commit 291a606 has been approved by jdm

bors-servo added a commit that referenced this pull request Mar 14, 2019
…h-function-call, r=jdm

clippy: Don't call expect with the result of a function call.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/295)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2019

Testing commit 291a606 with merge f8c1aaa...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing f8c1aaa to master...

@bors-servo bors-servo merged commit 291a606 into servo:master Mar 14, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@waywardmonkeys waywardmonkeys deleted the waywardmonkeys:clippy-core-foundation-expect-with-function-call branch Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.