Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGenerate both dylib and rlib for rustup #30
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
metajack
commented on 6762877
Apr 4, 2014
|
r+ |
metajack
added a commit
that referenced
this pull request
Apr 4, 2014
Generate both dylib and rlib for rustup
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Handle create_for_family() not matching any fonts to avoid crash.
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Do app activation in example through NSRunningApplication to get menubar to work Issue #98 and a comment in issue #30 both note that the example app has no menu bar when the app starts. This PR changes the activation logic to use NSRunningApplication instead of NSApplication to do the activation. On my Yosemite machine, this causes the menu bar to appear when the example app is started. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/cocoa-rs/102) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedApr 4, 2014
r? @metajack