Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-graphics: CGBeginDisplayConfiguration takes *mut. #305

Merged

Conversation

@waywardmonkeys
Copy link
Contributor

waywardmonkeys commented Mar 18, 2019

This was incorrectly saying it wanted a *const pointer, but the
value is modified and in the C headers, it is not const.


This change is Reviewable

This was incorrectly saying it wanted a *const pointer, but the
value is modified and in the C headers, it is not const.
@jdm
Copy link
Member

jdm commented Mar 18, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Mar 18, 2019

📌 Commit 9b217c5 has been approved by jdm

bors-servo added a commit that referenced this pull request Mar 18, 2019
…, r=jdm

core-graphics: CGBeginDisplayConfiguration takes *mut.

This was incorrectly saying it wanted a *const pointer, but the
value is modified and in the C headers, it is not const.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/305)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 18, 2019

Testing commit 9b217c5 with merge 5cbadc5...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 18, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 5cbadc5 to master...

@bors-servo bors-servo merged commit 9b217c5 into servo:master Mar 18, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@waywardmonkeys waywardmonkeys deleted the waywardmonkeys:missing-mut-pointer-core-graphics branch Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.