Skip to content

/ core-foundation-rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assert_eq! when possible instead of assert! #307

Merged
merged 1 commit into from Mar 21, 2019
Merged

Use assert_eq! when possible instead of assert! #307

merged 1 commit into from Mar 21, 2019
+35 −30

Conversation

@waywardmonkeys
Copy link
Contributor

waywardmonkeys commented Mar 21, 2019 •
edited by larsbergstrom

This change is Reviewable
@waywardmonkeys
Use assert_eq! when possible instead of assert!
Loading status checks…
0fbabb3
@jdm
Copy link
Member

jdm commented Mar 21, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 21, 2019

📌 Commit 0fbabb3 has been approved by jdm
bors-servo added a commit that referenced this pull request Mar 21, 2019
@bors-servo
Auto merge of #307 - waywardmonkeys:use-assert-eq-more, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
44c7a29 
Use assert_eq! when possible instead of assert!

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/307)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 21, 2019

⌛ Testing commit 0fbabb3 with merge 44c7a29...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 21, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 44c7a29 to master...
@bors-servo bors-servo merged commit 0fbabb3 into servo:master Mar 21, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@waywardmonkeys waywardmonkeys deleted the waywardmonkeys:use-assert-eq-more branch Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@waywardmonkeys @jdm @bors-servo
You can’t perform that action at this time.