Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd barebones NSSpellChecker bindings #312
Merged
+67
−1
Conversation
cocoa/src/appkit.rs
Outdated
| language: id, | ||
| wrapFlag: BOOL, | ||
| tag: NSInteger, | ||
| wordCount: *mut NSInteger) -> NSRange { |
This comment has been minimized.
This comment has been minimized.
jdm
Apr 29, 2019
Member
Let's return (NSRange, NSInteger) instead of accepting a mutable argument here.
This comment has been minimized.
This comment has been minimized.
cocoa/src/appkit.rs
Outdated
| language: id, | ||
| wrapFlag: BOOL, | ||
| tag: NSInteger) -> (NSRange, NSInteger) { | ||
| let wordCount = ptr::null_mut(); |
This comment has been minimized.
This comment has been minimized.
jdm
Apr 29, 2019
Member
This won't do the right thing. We should initialize let mut wordCount = 0;, pass a mutable reference as the argument, and return the value of wordCount.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 29, 2019
add barebones NSSpellChecker bindings Also adds `substringWithRange` to `NSString`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/312) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
euclio commentedApr 28, 2019
•
edited by larsbergstrom
Also adds
substringWithRangetoNSString.This change is