Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd some bindings for Appkit and Cocoa Foundation #315
Conversation
This commit adds several missing AppKit & Cocoa Foundation bindings. Specifically: AppKit: * NSWindowTabbingMode ([Apple Doc](https://developer.apple.com/documentation/appkit/nswindowtabbingmode?language=objc)) * Managing Window Tabs section for NSWindow ([Apple Doc](https://developer.apple.com/documentation/appkit/nswindow?language=objc#3020937)) * NSNib ([Apple Doc](https://developer.apple.com/documentation/appkit/nsnib?language=objc)) Cocoa Foundation * `init`, `count` and `objectAtIndex` for `NSArray` ([Apple Doc](https://developer.apple.com/documentation/foundation/nsarray?language=objc)) * `NSBundle` ([Apple Doc](https://developer.apple.com/documentation/foundation/nsbundle?language=objc))
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 6, 2019
Add some bindings for Appkit and Cocoa Foundation This commit adds several missing AppKit & Cocoa Foundation bindings. Specifically: AppKit: * NSWindowTabbingMode ([Apple Doc](https://developer.apple.com/documentation/appkit/nswindowtabbingmode?language=objc)) * Managing Window Tabs section for NSWindow ([Apple Doc](https://developer.apple.com/documentation/appkit/nswindow?language=objc#3020937)) * NSNib ([Apple Doc](https://developer.apple.com/documentation/appkit/nsnib?language=objc)) Cocoa Foundation * `init`, `count` and `objectAtIndex` for `NSArray` ([Apple Doc](https://developer.apple.com/documentation/foundation/nsarray?language=objc)) * `NSBundle` ([Apple Doc](https://developer.apple.com/documentation/foundation/nsbundle?language=objc)) I don't have much experience in Cocoa nor Objective-C. Please let me know if there is anything need to be changed. Thanks! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/315) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fanzeyi commentedMay 5, 2019
•
edited by larsbergstrom
This commit adds several missing AppKit & Cocoa Foundation bindings. Specifically:
AppKit:
Cocoa Foundation
init,countandobjectAtIndexforNSArray(Apple Doc)NSBundle(Apple Doc)I don't have much experience in Cocoa nor Objective-C. Please let me know if there is anything need to be changed. Thanks!
This change is