Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isARepeat #317

Merged
merged 1 commit into from Jun 11, 2019
Merged

Add isARepeat #317

merged 1 commit into from Jun 11, 2019

Conversation

@cmyr
Copy link
Contributor

cmyr commented Jun 6, 2019

closes #316


This change is Reviewable

@@ -2354,6 +2354,7 @@ pub trait NSEvent: Sized {
unsafe fn characters(self) -> id /* (NSString *) */;
unsafe fn charactersIgnoringModifiers(self) -> id /* (NSString *) */;
unsafe fn keyCode(self) -> libc::c_ushort;
unsafe fn isARepeat(self) -> bool;

This comment has been minimized.

@jdm

jdm Jun 6, 2019

Member

Use BOOL instead.

@@ -2602,6 +2603,10 @@ impl NSEvent for id {
msg_send![self, keyCode]
}

unsafe fn isARepeat(self) -> bool {

This comment has been minimized.

@jdm

jdm Jun 6, 2019

Member

Use BOOL instead.

@cmyr cmyr force-pushed the cmyr:add-isARepeat branch from 863e17e to 0d56822 Jun 7, 2019
@cmyr
Copy link
Contributor Author

cmyr commented Jun 11, 2019

@jdm updated.

@jdm
Copy link
Member

jdm commented Jun 11, 2019

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2019

📌 Commit 0d56822 has been approved by jdm

bors-servo added a commit that referenced this pull request Jun 11, 2019
Add isARepeat

closes #316

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/317)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2019

Testing commit 0d56822 with merge 05952a8...

@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 05952a8 to master...

@bors-servo bors-servo merged commit 0d56822 into servo:master Jun 11, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@cmyr cmyr deleted the cmyr:add-isARepeat branch Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.