Skip to content

/ core-foundation-rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NSColor argument order: r b<->g #322

Merged
merged 1 commit into from Jul 17, 2019
Merged

Fix NSColor argument order: r b<->g #322

merged 1 commit into from Jul 17, 2019

Conversation

@felixrabe
Copy link
Contributor

felixrabe commented Jul 14, 2019 •
edited by larsbergstrom

This change is Reviewable
@felixrabe
Fix NSColor argument order: r b<->g
Loading status checks…
8bc0ed0
@jdm
Copy link
Member

jdm commented Jul 17, 2019

@bors-servo r+
Weird that these methods were named this way originally!
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2019

📌 Commit 8bc0ed0 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2019

⌛ Testing commit 8bc0ed0 with merge d5e805c...
bors-servo added a commit that referenced this pull request Jul 17, 2019
@bors-servo
Auto merge of #322 - felixrabe:fix-nscolor, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d5e805c 
Fix NSColor argument order: r b<->g

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/322)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing d5e805c to master...
@bors-servo bors-servo merged commit 8bc0ed0 into servo:master Jul 17, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@felixrabe @jdm @bors-servo
You can’t perform that action at this time.