Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd alpha option to bind_to_gl_texture #324
Merged
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 17, 2019
Add alpha option to bind_to_gl_texture This PR is related to servo/servo#23509. If the WebGL context we use doesn't have alpha, the underlying IOsurface should use RGB internal format instead of RGBA, else the reported GL_ALPHA_BITS value will be incorrect fot the context in the related wpt-tests. We only need to change the internal format in this case, according to https://github.com/phracker/MacOSX-SDKs/blob/master/MacOSX10.8.sdk/System/Library/Frameworks/OpenGL.framework/Versions/A/Headers/CGLIOSurface.h#L99 cc @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/324) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zakorgy commentedJul 17, 2019
•
edited by larsbergstrom
This PR is related to servo/servo#23509.
If the WebGL context we use doesn't have alpha, the underlying IOsurface should use RGB internal format instead of RGBA, else the reported GL_ALPHA_BITS value will be incorrect fot the context in the related wpt-tests.
We only need to change the internal format in this case, according to https://github.com/phracker/MacOSX-SDKs/blob/master/MacOSX10.8.sdk/System/Library/Frameworks/OpenGL.framework/Versions/A/Headers/CGLIOSurface.h#L99
cc @jdm
This change is