Skip to content

/ core-foundation-rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds setTarget to buttons and menu items, these are required in many … #333

Merged
merged 1 commit into from Sep 25, 2019
Merged

Adds setTarget to buttons and menu items, these are required in many … #333

merged 1 commit into from Sep 25, 2019

Conversation

@seanvoss
Copy link
Contributor

seanvoss commented Sep 25, 2019 •
edited by larsbergstrom

…cases

This change is Reviewable
svoss
Adds setTarget to buttons and menu items, these are required in many …
Loading status checks…
4372c04 
…cases
@jdm
Copy link
Member

jdm commented Sep 25, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

📌 Commit 4372c04 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

⌛ Testing commit 4372c04 with merge 7511460...
bors-servo added a commit that referenced this pull request Sep 25, 2019
@bors-servo
Auto merge of #333 - seanvoss:add_target, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7511460 
Adds setTarget to buttons and menu items, these are required in many …

…cases

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/333)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 7511460 to master...
@bors-servo bors-servo merged commit 4372c04 into servo:master Sep 25, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@seanvoss @jdm @bors-servo
You can’t perform that action at this time.