Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CFDataGetBytes to CFData bindings #337

Merged
merged 1 commit into from Oct 15, 2019
Merged

Conversation

@wezm
Copy link
Contributor

wezm commented Oct 11, 2019

Just add a missing binding that I needed.

This change is Reviewable

@jdm
Copy link
Member

jdm commented Oct 11, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

📌 Commit 6dac80f has been approved by jdm

bors-servo added a commit that referenced this pull request Oct 11, 2019
Add CFDataGetBytes to CFData bindings

Just add a missing binding that I needed.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/337)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

Testing commit 6dac80f with merge 37cb6a2...

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 37cb6a2 to master...

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@wezm wezm force-pushed the wezm:CFDataGetBytes branch from 6dac80f to b2a4a0e Oct 14, 2019
@wezm
Copy link
Contributor Author

wezm commented Oct 15, 2019

I rebased this but looks like it needs a nudge to rebuild.

@jdm
Copy link
Member

jdm commented Oct 15, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2019

📌 Commit b2a4a0e has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2019

Testing commit b2a4a0e with merge c9b0702...

bors-servo added a commit that referenced this pull request Oct 15, 2019
Add CFDataGetBytes to CFData bindings

Just add a missing binding that I needed.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/337)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing c9b0702 to master...

@bors-servo bors-servo merged commit b2a4a0e into servo:master Oct 15, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.