Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CGConfigureDisplayMirrorOfDisplay #344

Merged
merged 3 commits into from Oct 24, 2019
Merged

Add CGConfigureDisplayMirrorOfDisplay #344

merged 3 commits into from Oct 24, 2019

Conversation

@zubivan
Copy link
Contributor

zubivan commented Oct 24, 2019

Hi there,

One more for Core Graphics from me. This time adds CGConfigureDisplayMirrorOfDisplay and kCGNullDirectDisplay APIs.

CGConfigureDisplayMirrorOfDisplay:

func CGConfigureDisplayMirrorOfDisplay(_ config: CGDisplayConfigRef?, 
                                     _ display: CGDirectDisplayID, 
                                     _ master: CGDirectDisplayID) -> CGError

kCGNullDirectDisplay:

#define kCGNullDirectDisplay

Not sure about the null_display function, but at least it kind of aligns with main. Maybe I should just call it null.

Let me know what do you think.

zubivan added 3 commits Oct 24, 2019
Value used to reset mirroring settings to default
@jdm
Copy link
Member

jdm commented Oct 24, 2019

@bors-servo r+
Looks good!

@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2019

📌 Commit 0f5dfff has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2019

Testing commit 0f5dfff with merge cac6d10...

bors-servo added a commit that referenced this pull request Oct 24, 2019
Add CGConfigureDisplayMirrorOfDisplay

Hi there,

One more for Core Graphics from me. This time adds [`CGConfigureDisplayMirrorOfDisplay`](https://developer.apple.com/documentation/coregraphics/1454531-cgconfiguredisplaymirrorofdispla) and [`kCGNullDirectDisplay`](https://developer.apple.com/documentation/coregraphics/kcgnulldirectdisplay) APIs.

`CGConfigureDisplayMirrorOfDisplay`:
``` objc
func CGConfigureDisplayMirrorOfDisplay(_ config: CGDisplayConfigRef?,
                                     _ display: CGDirectDisplayID,
                                     _ master: CGDirectDisplayID) -> CGError
```

`kCGNullDirectDisplay`:
``` objc
#define kCGNullDirectDisplay
```

Not sure about the `null_display` function, but at least it kind of aligns with `main`. Maybe I should just call it `null`.

Let me know what do you think.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing cac6d10 to master...

@bors-servo bors-servo merged commit 0f5dfff into servo:master Oct 24, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.