Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBump core graphics version to 0.18.0 #345
Merged
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 28, 2019
|
|
|
Published. |
|
@jdm thanks! |
|
core-graphics is exposed in core-text's public API. This should have been a core-text breaking change. Please don't update crates without updating the others, now I have releases to yank. |
|
To be clear - nothing in this PR is incorrect, because core-text's version was not updated at all. I did a major version update in #346. |
|
My complaint is that there was no paper trail that there were unpublished breaking changes in the tree, and thus core-text actually needed a breaking bump.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zubivan commentedOct 26, 2019
As discussed in #339 bumping version of core graphics to the next minor.