Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated usage of Rust features #350

Merged
merged 4 commits into from Nov 12, 2019
Merged

Conversation

@lqf96
Copy link
Contributor

lqf96 commented Nov 12, 2019

This PR fixes some deprecated usage of Rust features. However, because of the use of MaybeUninit this PR will bump the minimum required Rust version to 1.36, which will need some discussion.

Copy link
Member

jdm left a comment

These changes look fine, and we're getting semver-major version increase in #349, so increasing the minimum supported rust version seems fine to me.

core-foundation/src/url.rs Outdated Show resolved Hide resolved
@jdm
Copy link
Member

jdm commented Nov 12, 2019

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2019

📌 Commit 83b6f5d has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2019

Testing commit 83b6f5d with merge 0718126...

bors-servo added a commit that referenced this pull request Nov 12, 2019
Fix deprecated usage of Rust features

This PR fixes some deprecated usage of Rust features. However, because of the use of `MaybeUninit` this PR will bump the minimum required Rust version to 1.36, which will need some discussion.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 0718126 to master...

@bors-servo bors-servo merged commit 83b6f5d into servo:master Nov 12, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@lqf96 lqf96 deleted the lqf96:fix-deprecated-usage branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.