Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd binding for CTRunGetStringIndices #353
Merged
Conversation
|
I added an unrelated commit that just fixes a few warnings in the codebase, because I wanted to depend on this branch in another project. If you'd prefer these fixes not be included in this PR, I can remove that commit. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 9, 2020
Add binding for CTRunGetStringIndices This PR adds a `CTRun::string_indices` method, which exposes CoreText's `CTRunGetStringIndices`/`CTRunGetStringIndicesPtr` API. The implementation is basically identical to `CTRun::glyphs` and `CTRun::positions`. I added an assertion about the new method in the existing unit test.
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
maxbrunsfeld commentedJan 9, 2020
This PR adds a
CTRun::string_indicesmethod, which exposes CoreText'sCTRunGetStringIndices/CTRunGetStringIndicesPtrAPI. The implementation is basically identical toCTRun::glyphsandCTRun::positions.I added an assertion about the new method in the existing unit test.