Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd CGGradient and CGContext gradient draw functions #365
+82
−0
Conversation
|
@bors-servo r+ |
|
|
|
|
Merged
bors-servo
added a commit
that referenced
this pull request
Jun 26, 2020
Fix build on iOS #365 broke iOS, since `bitflags` was used despite `bitflags` only being included on macOS. Since it looks like the `CGGradient` API is supported on iOS as well, I fixed this by just removing the `#[cfg(target_os = "macos")]` line on `extern crate bitflags`. If I made a follow-up PR that adds iOS to CI, would that be welcome?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
brunogouveia commentedApr 13, 2020
This PR adds the following missing APIs:
core_graphics::gradientmodule.core_graphics::contextmodule.