Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate for rustc #39
Merged
Update for rustc #39
+1
−2
Conversation
This comment has been minimized.
This comment has been minimized.
metajack
commented on 1d5759a
Oct 14, 2014
|
r+ |
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Bump euclid to 0.2 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/io-surface-rs/39) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Made core-foundation a dependency for any platform The Cargo.toml file currently only declares `core-foundation` as a dependency on 64bit OSX, but it's used unconditionally in this crate so it should be an unconditional dependency. I'm playing around with this crate on iOS and it won't build without this change. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/39) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tomaka commentedOct 14, 2014
Rust now longer allows multiple
#[cfg]attributes on the same itemI'm not sure whether the old code means
test OR macosortest AND macos, but putting anORhere doesn't really make sense.