Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed a compilation error: mut_null changed to null_mut in rust #42
+3
−3
Conversation
metajack
added a commit
that referenced
this pull request
Oct 23, 2014
Fixed a compilation error: mut_null changed to null_mut in rust
ghost
deleted the
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Add accessors for bounds and frame to NSView.
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Allow the URL of the Core Text font to be fetched. This allows FreeType to load Core Text fonts, which is necessary for WebRender (unless we want a Quartz backend for WebRender). r? @glennw <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/42) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Fix CGFloat type definition for 32-bit `CGFloat` was always defined as a double, and there was a `TODO` to fix this. I ran into the issue, so here's a PR to fix it :) The definition for `CGFloat` in CoreGraphics/CGBase.h looks like: ``` c #if defined(__LP64__) && __LP64__ # define CGFLOAT_TYPE double #else # define CGFLOAT_TYPE float #endif typedef CGFLOAT_TYPE CGFloat; ``` I also noticed that the definition for `boolean_t` was wrong for arm. The definition in mach/arm/boolean.h is: ``` c typedef int boolean_t; ``` And the definition in mach/i386/boolean.h is: ``` c #if defined(__x86_64__) && !defined(KERNEL) typedef unsigned int boolean_t; #else typedef int boolean_t; #endif ``` <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/42) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Set libc version to 0.1 This is necessary because libc 0.2 exists now and we need to have all Servo dependencies using an explicit version. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/io-surface-rs/42) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ghost commentedOct 23, 2014
No description provided.