Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChanged from_str to str #46
Merged
Conversation
ghost
deleted the
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Add method to get scroll delta from NSEvent.
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Support serialization of `CGFont` objects. Due to API limitations, this will only serialize native fonts, not Web fonts. Specifically, there is no way I know of to fetch the `CGDataProvider` associated with a `CGFont`. This isn't a problem for Servo, however, because Servo knows which fonts are Web fonts and stores their byte data separately. r? @glennw or @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/46) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Update core-graphics dependency to 0.2 This is what the rest of Servo is using -- so bump it here as well to avoid test-tidy failure. Note that this is indeed the version Servo is currently using core-text with (as Servo still has a revision of core-text that didn't specify any version constraints) -- so we are rather certain that this combination works. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/46) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ghost commentedNov 19, 2014
No description provided.