Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate for 1.0.0-alpha compatibility #50
Merged
Conversation
src/dictionary.rs
Outdated
| @@ -152,7 +153,7 @@ impl CFDictionary { | |||
| pub fn get(&self, key: *const c_void) -> *const c_void { | |||
| let value = self.find(key); | |||
| if value.is_none() { | |||
| panic!("No entry found for key: {}", key); | |||
| panic!("No entry found for key [FIXME]"); // FIXME Not sure how to convert key to be printed | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@Ms2ger your suggestion worked, thanks. |
This comment has been minimized.
This comment has been minimized.
metajack
commented on 14ac9f2
Jan 11, 2015
|
r+ |
metajack
added a commit
that referenced
this pull request
Jan 11, 2015
Update for 1.0.0-alpha compatibility
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Added NSOpenGLPFAOpenGLProfile values
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Add binding for CTFontGetUnitsPerEm Needed for implementing fast-path kerning on Mac OS. r? @pcwalton <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/50) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Add some bindings to the private `CGSRegion` APIs. These enable us to tell the window server about the opaque regions of the window so that it can perform occlusion culling. See https://github.com/NUIKit/CGSInternal/blob/master/CGSRegion.h r? @metajack <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/50) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Allow euclid 0.7 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/io-surface-rs/50) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sbward commentedJan 10, 2015
cargo test(passing)