Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix Show implementations for Rust nightly #52
Merged
Conversation
|
This is backwards compatible, unlike #51, so should get us over the line. This is currently breaking downstream libs, like glutin and gfx-rs |
This comment has been minimized.
This comment has been minimized.
larsbergstrom
commented on cdb8aea
Jan 25, 2015
|
r+ |
larsbergstrom
added a commit
that referenced
this pull request
Jan 25, 2015
Fix Show implementations for Rust nightly
jdm
added a commit
that referenced
this pull request
Feb 1, 2018
Fix dangling pointer with `to_c_str().as_mut_ptr()`
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Test on stable. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/52) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
brendanzab commentedJan 25, 2015
No description provided.